The process for publishing the build artifacts of the GrapesJS repository has had the following issues: Artifacts are expected to come directly from developers' machines. - https://github.com/GrapesJS/grapesjs/pull/6041 The process is undocumented We have multiple packages to release, and proper documentation is also...
GJS Helper
The issues regarding the GrapesJS release process โ specifically, the reliance on developer machines for artifacts and the lack of documentation โ highlight a need for a standardized, automated, and transparent workflow. Adopting an indust...
The current codebase relies on commit hooks to enforce certain rules and checks. This ticket aims to: Remove existing commit hooks. Configure CI runners to perform these checks and report issues on the development branch or pull requests. Shifting these responsibilities to the CI runners will streamline the developmen...
The request to remove client-side commit hooks and shift their responsibilities to CI runners is a sound strategy for improving development workflow consistency and reliability. While this is a general software development practice and not...
The codebase currently uses outdated linting tools and formatting libraries. This ticket aims to: Upgrade to the latest versions of linting tools and formatting libraries. Ensure consistent linting and formatting rules across all projects. Integrate these tools into the development and CI pipelines for automated enfor...
GJS Helper
Standardizing linting and formatting is crucial for maintaining code quality and a cohesive development environment within the GrapesJS codebase. This initiative will significantly improve developer experience and reduce potential errors....
Across the codebase, we have built and linked dependencies against very old versions of Node.js. See: https://github.com/GrapesJS/grapesjs/blob/dev/.github/workflows/publish.yml#L15 https://github.com/GrapesJS/grapesjs/blob/dev/.github/workflows/build.yml#L15 https://github.com/GrapesJS/grapesjs/discussions/5973 https...
The issue correctly identifies that GrapesJS's CI/CD workflows and development recommendations currently rely on older Node.js versions (specifically Node.js 16.x). Updating these to the latest Long Term Support (LTS) version, Node.js 20.x...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Version 127.0.6533.89 (Official Build) (64-bit) Reproducible demo link Describe the bug Please check this.selected has a value of undefined . I used it in react and got an error exception. /*Returns model of the selected c...
artf
Hey @Vampire-V please follow properly the bug issue template. We can't help you here without a reproducible demo.
Aravinth-2020
### GrapesJS version[x] I confirm to use the latest version of GrapesJS### What browser are you using?Version 127.0.6533.89 (Official Build) (64-bit)### Reproducible demo link### Describe the bugPlease check this.selected has a value of un...
Aravinth-2020
Hey @Vampire-V please follow properly the bug issue template. We can't help you here without a reproducible demo. Can you please share the solution for that? I have a same issue when i select the open layer manager, this issue raises after...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome 126 Reproducible demo link https://jsfiddle.net/Gryphonn/ob1pznh6/ Describe the bug How to reproduce the bug?Select any word.Wrap it for style.Keep this word selected.Go to General -> DisplayI want Block. I click Bl...
artf
Yeah, the issue is here: https://github.com/GrapesJS/grapesjs/blob/1e3766f0060e6da502fccf9ba9eb938d5ac860bb/src/style_manager/model/PropertyFactory.ts#L267 Would it make sense to add a new option like initial and make it the default one?
danstarns
> Hi @Gryphonn,> I tried to reproduce your issue but the steps aren't that clear, please rephrase. bandicam.2024-08-08.21-07-14-667.mp4 Thank you for a detailed report ๐ It looks like we should better handle the default display so you don...
danstarns
Hi @Gryphonn, I tried to reproduce your issue but the steps aren't that clear, please rephrase.
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? ChromeReproducible demo link https://jsfiddle.net/6bn43a05/Describe the bug How to reproduce the bug?Add a onclick event for a html tag What is the expected behavior? It should not remove the event after getting loaded in to...
artf
This is intentional for security reasons, but you can disable it with the option config.parser.optionsHtml.allowUnsafeAttr (at your own risk): https://github.com/GrapesJS/grapesjs/blob/819bfcf44bb23d51990eba3b4330e9932df59cde/src/parser/co...
GJS Helper
The issue you're encountering, where onclick attributes are removed from HTML elements when loaded into GrapesJS, is a deliberate security feature and part of GrapesJS's HTML sanitization process. GrapesJS, like many modern HTML editors, s...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome v126 Reproducible demo link https://grapesjs.com/demo Describe the bug How to reproduce the bug?Open the demoDouble-click on any existing image component to open the asset manager.Drag and drop a video file into the...
artf
Thanks @aswinkumar863 for the report. I'll be happy to merge a PR of the fix.
GJS Helper
The issue you've reported, where the GrapesJS Image component allows video files to be uploaded and selected via drag and drop, is a common scenario when the default asset manager's drag-and-drop handler doesn't explicitly enforce file typ...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Reproducible demo link https://codepen.io/Harshsne/pen/xxoOyXO Describe the bug https://github.com/GrapesJS/grapesjs/issues/6019 with reference to this, I wanted to hide rte only for some particular type . Example:...
The issue describes a common need to conditionally control the Rich Text Editor (RTE) in GrapesJS, specifically preventing it from activating for certain component types, such as 'link' components. While GrapesJS automatically enables RTE...
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Reproducible demo link https://codepen.io/Harshsne/pen/xxoOyXO Describe the bug How to reproduce the bug?drop text componentedit text component What is the expected behavior? rte shouldnt be displayed What is the cu...
artf
Yeah onActive is now an async method so extending it with extendFnView is not enough, your code is executed before the original one. Anyway, you can achieve the same result with a simple line of CSS
yashvi2026
but i wanted to hide only some particular type eg:text @artf
artf
You can still extend the view without using extendFnView. Reuse the original component type via prototype, as indicated in here.