[BUG] Intermittent test failure on `dev` branch due to race condition

I recommend adding --bail after the mocha command in package.json's test to make this easier to see, e.g.:

"test": "cross-env NODE_PATH=./src mocha --bail --compilers js:babel-core/register --require test/helper.js --timeout 10000 --recursive test/main.js",

On the latest dev branch, this is easy to reproduce by simply running npm test many times:

npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test && npm test

Sooner or later you will get:

  1 failing

  1) Main SelectorManager Views E2E tests "before each" hook:
     Uncaught TypeError: this.get(...).getComponent is not a function
      at child.getCss (src/editor/model/Editor.js:308:43)
      at Object.store (src/css_composer/index.js:154:52)
      at src/editor/model/Editor.js:345:19
      at Array.forEach (<anonymous>)
      at child.store (src/editor/model/Editor.js:344:27)
      at child.updateChanges (src/editor/model/Editor.js:119:12)
      at triggerEvents (node_modules/backbone/backbone.js:371:57)
      at triggerApi (node_modules/backbone/backbone.js:356:19)
      at eventsApi (node_modules/backbone/backbone.js:155:16)
      at child.Events.trigger (node_modules/backbone/backbone.js:346:5)
      at child.set (node_modules/backbone/backbone.js:516:16)
      at Timeout._onTimeout (src/editor/model/Editor.js:187:14)

This seems to go away if you .skip this test in test/specs/selector_manager/e2e/ClassManager.js on line 74:

it.skip('Class imported into component is the same model from main container', function() {
          var model = components.add({ classes: ['test1'] });
          var clModel = model.get('classes').at(0);
          var clModel2 = gjs.editor
            .get('SelectorManager')
            .getAll()
            .at(0);
          expect(clModel).toEqual(clModel2);
        });

Of course, that's not a solution. But it may indicate what the underlying issue is. It looks like a race condition of some sort.

It also goes away if you comment out the event listeners editor/model/Editor.js:

// Load modules
    deps.forEach(name => this.loadModule(name));
    // this.on('change:selectedComponent', this.componentSelected, this);
    // this.on('change:changesCount', this.updateChanges, this);

Perhaps the modules have not entirely loaded yet and there are already changes to be processed? Resulting in const wrp = this.get('DomComponents').getComponent(); on line 308 in Editor.js to throw.

Should we wait for all modules to have loaded prior to attaching the event listeners?