[Fix] Fix and refactor Sorter.ts

Question

[x] Fix the Sorter usage in StyleManager (regression with sorting property layers) [x] Refactor Sorter with the usage of Components.canMove [x] Update canMove with the check of dropping main Symbol inside its own instance.

mohamedsalem401 · Accepted Answer

This's done.

mohamedsalem401 · Answer

The idea is to refactor the sorter for improved maintainability and readability. We can implement the following changes:Make Sorter class depend on an abstract tree structure rather than relying on specific implementations like Component or Layers, make the Sorter class work with a more generic, abstract tree structure. This will make it more flexible and reusable.Split the code to multiple smaller classes each with a single responsibilityComponentManager.canMove: Use the ComponentManager.canMo...

GJS Helper · Answer

This fix and refactoring addresses several key areas within GrapesJS's Sorter.ts and component movement logic, resolving a regression in the Style Manager and enhancing the overall drag-and-drop experience, especially concerning reusable components (Symbols). Fix Sorter usage in StyleManager (regression with sorting property layers) Problem: A regression was introduced where the StyleManager's ability to sort property layers (e.g., multiple box-shadow or text-shadow values) via drag-and-drop wa...

Fix and refactor Sorter.ts

Question

Answers (3)

Related Questions and Answers

component:styleUpdate / component:styleUpdate:propertyName not fired

update() of custom types added to StyleManager is no more triggered when switching between some targets.

When I select an particular element I'm not getting its styles. This issue happens only with some elements.

Symbol styles not synced

Paid Plugins That Match This Issue

Browse Plugin Categories