BUG: CSS Parser's shape doesn't allow the CSS property to be defined more than once.
Question
GrapesJS version
- I confirm to use the latest version of GrapesJS
What browser are you using?
Any
Reproducible demo link
https://grapesjs.com/demo.html
Describe the bug
The bug is related to ParserCss.js.
https://github.com/artf/grapesjs/blob/dev/src/parser/model/ParserCss.js#L7-L8
The parser expects the results to be stored in an array of a hash object containing a select string and a style hash object (and other media query arguments).
Example Result:
[
{
selects: "div, a, .a.b.c", //some selector with comma separtator.
style: {
background-image: url(img/gradient.png);
}
}
]
This prevents CSS from having the same property defined more than once and this is needed for better backward compatibility. The CSS is valid, but the editor will not be able to output the correct HTML.
Example CSS
div, a, a.b.c {
background-image: url(img/gradient.png);
background-image: -webkit-linear-gradient(to bottom, #dddddd, #aaaaaa);
background-image: -moz-linear-gradient(to bottom, #dddddd, #aaaaaa);
background-image: linear-gradient(to bottom, #dddddd, #aaaaaa);
}
Step to Reproduce in Demo:
Drop a custom block Insert
<div style=" background-image: url(img/gradient.png);
background-image: -webkit-linear-gradient(to bottom, #dddddd, #aaaaaa);
background-image: -moz-linear-gradient(to bottom, #dddddd, #aaaaaa);
background-image: linear-gradient(to bottom, #dddddd, #aaaaaa);">
hello
</div>
Export to HTML
Expected Behavior: All the CSS styling should be available in the HTML in the correct order
Current Behavior:
Only one of the background-image is exported.
https://user-images.githubusercontent.com/5863227/178131872-13726a77-5264-4d2a-9131-ed1e205387a2.mp4
Code of Conduct
- I agree to follow this project's Code of Conduct
Answers (1)
Yeah, this is something we don't support currently, but I think it might be nice to handle also those cases.
Related Questions and Answers
Continue research with similar issue discussions.
Issue #4735
BUG: resetId types mismatch
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? n/a Reproducible demo link n/a Describe th...
Issue #4401
BUG: resizer does not work with touch - draggable attribute not set on handlers
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? Chrome Version 102.0.5005.115 (Official Bu...
Issue #4323
BUG: Performance issue while dragging component to canvas when you have 2k component on canvas
GrapesJS version[X] I confirm to use the latest version of GrapesJSWhat browser are you using? Google Chrome Version 101.0.4951.41 (Officia...
Issue #4797
BUG: change type keepUnusedStyles?: 0;
GrapesJS version [X] I confirm to use the latest version of GrapesJS What browser are you using? any Reproducible demo link n/a Describe th...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.