Issue #3317Opened March 5, 2021by martijnc0 reactions

FEAT: Add support for promises to custom RTE API

Question

What are you trying to add to GrapesJS? Support for richtext editors with promise based APIs.

Describe your feature request detailed CKEditor5's Editor.create and Editor.destroy methods return a Promise that resolves when the editor has been fully created or destroyed. This causes an issue when destroying the editor (when you finish editing a component) because GrapesJS syncs the changes to the model before the Editor.destroy promise has resolved which causes CKEditor HTML to be written to the model.

As a workaround you can sync the content again after the promise has resolved but it would be cleaner if the API supported promises.

We could add this in a backward compatible way be checking if the return values of the RTE's enable and disable methods are thennable and, if so, wait for the promise to resolve before continuing.

Is this something GrapesJS would consider supporting?

Is there an alternative at the latest version? No

Is this related to an issue? https://github.com/artf/grapesjs/issues/1516 https://github.com/artf/grapesjs/issues/1236

Answers (2)

artfMarch 12, 20210 reactions

Yeah, makes sense, probably I'd try to check if it's possible to make enable/disable methods (from ComponentTextView) async by default without breaking stuff, but checking if are thennable is always an option.

artfFebruary 8, 20220 reactions

This should be already possible.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.