Warning on setting up wrapper's height to 100%
Question
Hi @artf I hope everything's going well.
This is more like a reminder or a warning message for an issue I've just had that it took me some time to figure out.
if the wrapper's height (modified by the selector #wrapper by default) is set to height: 100%; instead of min-height: 100%, the editor's tool container will take a non desirable behavior.

This happens because the scroll event will not be triggered by the window object but rather the wrapper element, this causes the onFrameScroll not to be fired in the CanvasView.
The OnFrameScroll is assigned in the renderBody function.
...
body.append('<style>' + frameCss + '</style>');
body.append(wrap.render()).append(cssc.render());
body.append(this.getJsContainer());
em.trigger('loaded');
**this.frame.el.contentWindow.onscroll = this.onFrameScroll;**
this.frame.updateOffset();
...
Should this warning be written somewhere in the code? Maybe in the editor configuration file where the baseCSS is set, along with the comments you have there.
What do you think?
Thanks!
Answers (3)
Hi Juan, thank you for all the details, I'm going to merge soon a big canvas refactoring and will see if we can fix it (eg. attaching scroll callback to the wrapper)
Thanks for the reminder @bgrand-ch I actually forgot about this issue 😬 Will be fixed in the next release.
Glad to hear it, i hope the refactoring helps to fix the issue.
Related Questions and Answers
Continue research with similar issue discussions.
Issue #1346
[FEATURE REQUEST] Property slider view default unit
Hey @artf , I think that the slider component would come handy from the UX perspective for the user interaction of some of the integer prop...
Issue #1410
Drag placeholder Highlighter Postion
@artf When we set some margin from top to the container and want to drag some element inside it then Drag placeholder Highlighter position...
Issue #644
Upgrade to Fontawesome 5
From fontawesome 4. Would be a good opportunity to make fa5 a peer-dependency this time as well, so people aren't including it twice Some i...
Issue #1577
Inline CSS Comments break Code Manager
Apparently this is valid piece of html and css: <div style="color: red; / height 200px; /; font-weight: bold;"> (Hence the commented out he...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.