Issue #1881πŸ’¬ AnsweredOpened March 12, 2019by lucasschirm0 reactions

Commands with a stop method, never programmatically stoped don`t run again!

Quick answerby artf

Hi @lucasschirm and thanks for the report. As you've might notice this is the breaking change we've introduced in the latest version https://github.com/artf/grapesjs/releases/tag/v0.14.55 The reason behind it is quite simple. If you create a command with start and stop command you explicitly declare it as stateful one...

Read full answer below ↓

Question

Problem When you add a custom command with stop and dont stop will not run again if I dont set force: 1 as a parameter when running. When you add a custom command with a stop method like: var fired = 0; editor.Commands.add('custom-command', { run() { fired++; console.log("fired ", fired); }, stop() { console.log("Command stoped"); } }); and if never run stop, the run method will never fired again. editor.Commands.run('custom-command'); editor.Commands.run('custom-command'); editor.Commands.stop('custom-command'); editor.Commands.run('custom-command'); should print fired 1 fired 2 stoped fired...

Answers (3)

artfβ€’ March 22, 2019

Hi @lucasschirm and thanks for the report. As you've might notice this is the breaking change we've introduced in the latest version https://github.com/artf/grapesjs/releases/tag/v0.14.55 The reason behind it is quite simple. If you create a command with start and stop command you explicitly declar...

lucasschirmβ€’ March 22, 2019

Thank you, I've sended an PR about the modal closing not firing the modal I close trigger. On Thu, Mar 21, 2019, 3:14 PM Artur Arseniev <[email protected]> wrote: Hi @lucasschirm <https://github.com/lucasschirm> and thanks for the report. As you've might notice this is the breaking change we...

lock[bot]β€’ March 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Related Questions and Answers

Continue research with similar issue discussions.

Paid Plugins That Match This Issue

Curated by issue keywords and label relevance to help you ship faster.

View all plugins

Loading paid plugin recommendations...

Free option

Check the open-source GrapesJS plugins on GitHub or run a quick search in our free catalog.

Browse free plugins β†’
Premium option

Premium plugins ship with support, regular updates, and production-ready features β€” save days of integration work.

Browse premium plugins β†’

Related tutorials

In-depth guides on the same topic.

All tutorials β†’

Browse Plugin Categories

Jump directly to plugin category pages on the marketplace.