GrapesJS Issues

Search parsed GitHub issues, see highlighted answers, and open the original discussion when needed.

1180 issues found

#2693April 1, 2020by mazuschlag3 answers
1 reactions

[BUG] Rich Text Editor's position is not updated on enter/return

Once again thanks for all the hard work on the project! This is reproducible on the current release 0.16.3 - you can check it out in the newsletter demo: https://grapesjs.com/demo-newsletter-editor.html Normally the RTE appears above the element so this is not an issue. However, when a RTE-enabled element is placed cl...

khurram900

@mazuschlag if you are using ckeditor then you can try this patch. It will re-calculate and re-position the ckeditor to the correct position. CKEDITOR.on('instanceReady', function (e) { editor.RichTextEditor.updatePosition(); });

artf

Canvas tools should be updated on input event of the text component, in the current version there is an issue even with the built-in RTE but it will be fixed in the next release. Somehow, this issue doesn't affect the CKEditor plugin but,...

mazuschlag

@artf Thanks for the response but I'm a little confused. This is happening with the CKEditor plugin - are you saying the fix will be separate from the fix to the built in CKEditor? I wouldn't mind fixing it but do you have some pointers on...

#2692April 1, 2020by mazuschlag3 answers
0 reactions

[BUG] Quick mouse clicks/movements can cause the editor to freeze

First off thanks for all your hard work on the project! This is a very great project that a lot of people depend upon, so thanks for your effort. This is a weird one, but the basic gist of it is that moving your mouse quickly as you click on an element can cause the builder to freeze. This isn't always a huge problem...

artf

Hi @mazuschlag and thanks for your kind words. About the issue, can you elaborate better on the click and move behavior? Should I just select one component and only move around the mouse? There was an issue with moving around components th...

mazuschlag

Hmm that does sort of sound like the problem I was experiencing. This involves holding down the left click on the mouse as you quickly drag a component before releasing it. This happens when working quickly - you click on a component and a...

artf

@mazuschlag so, are you using an old version or the latest of grapesjs? I'm not able to reproduce it on the latest

#2683March 25, 2020by longdoan74212 answers
0 reactions

[BUG] When cancel Colorpicker, it set wrong value for component

Are you using the latest release (older versions are NOT supported)? Yes.Are you facing the bug with your local copy of GrapesJS or with the current demo? Both of them.Steps to reproduce:Drag a component then change its background color from inputOpen color picker immediatelyThen click to outside color picker (anywher...

longdoan7421

Hi @artf, After seeing around the colorpicker, I think the problem is that the spectrum doesn't have the same value as model when user changes input. So I attempted to sync the value of spectrum and model, and it could fix the issue. Here...

longdoan7421

I found out that this bug also happen if you change the input with any value, then immediately open colorpick then cancel it by clicking outside (not canvas).

#2681March 24, 2020by wemod1233 answers
2 reactions

[BUG]: destroy() method didn't fully remove events

version: latest: v-0.16.3. important: update from v-0.15.9 to v-0.16.3 while keep everything same, the error will show in console: This error show there is a errro in function getFrameOffset, near position: e.ownerDocument.defaultView.frameElement: Refer to This Code Line Checking the error stack will track to This Co...

emilsedgh

I agree that this needs to be reopened and fixed within the destroy function itself.

emilsedgh

Thank you @artf ! 🙏

artf

Thanks for the report @wemod123 Are you able to create a reproducible live demo of the issue?

#2664March 18, 2020by Podvodila2 answers
2 reactions

[Bug] getComponents method doesn't return tree of components

I'm trying to implement multiple pages as per discussion in that issue - https://github.com/artf/grapesjs/issues/1331 But when I trying to get components tree by using 'editor.getComponents()' it returns data with wrong format(model collection I guess). When I try to set components using the editor.SetComponents metho...

Podvodila

Need to stringify and parse back returned components(works only if components were set programmatically initially) JSON.parse(JSON.stringify(editor.getComponents())) https://jsfiddle.net/w1497xp8/ Upd.: same with editor.getStyles() method

artf

Yes, this is the correct way to obtain the same string of the StorageManager

#2663March 17, 2020by h3llomoto2 answers
0 reactions

[BUG] WASD keypress returns an errror at Canvas

Hi there, I get an error on a keypress at canvas without RTE enabled. Uncaught TypeError: Cannot read property 'hasFocus' of null node_modules/grapesjs/src/canvas/index.js:544

artf

What do you mean by without RTE enabled? I'm not able to reproduce it. Create a live demo with all the necessary steps, please

no-response[bot]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...

#2661March 16, 2020by h3llomoto2 answers
0 reactions

[BUG] toggleStateCls returns js error

Hi there, guys. I found a bug at the LayerManager: I've got an html comment as a layer in the LM. I click the comment. I get an error at the console: And the code this error relates to is: src/style_manager/view/SectorsView.js:47 So, html comments cant have classList property and this is the bug.

artf

Can you create a live demo, please? By default definition, you shouldn't be able to see Comment component in Layers

no-response[bot]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...

#2657March 16, 2020by Podvodila3 answers
0 reactions

[Bug]: custom style property is not working when toRequire attribute is set

Are you using the latest release (older versions are NOT supported)? YesWhat is the expected behavior? Custom style property applying to componentWhat happens instead? Custom style property is not workingSteps to reproduceselect Box componenttry to change Box Width style property (under Custom tab) When I add custom s...

Podvodila

I managed to hotfix it by extending isTargetStylable method inside PropertyView.js - https://github.com/artf/grapesjs/blob/85b7b82103e12fb01a3700b1002a57a7b60ccaf1/src/style_manager/view/PropertyView.js#L504-510 I replaced thisif (toRequir...

Podvodila

Offtop I don't want to create another topic, just want to say that in the same method(isTargetStylable) that would be better to replace searching for property with id(as I understand for the built-in styles, it is the same as the property)...

artf

would be better to replace searching for property with id(as I understand for the built-in styles, it is the same as the property) inside unstylable(as well as stylable) check Yeah, totally correct! Honestly, I use toRequire option and nev...

#2656March 16, 2020by abozhinov3 answers
1 reactions

[BUG] Wrong position of toolbar when duplicate children component

Hi, you can check this example: https://codepen.io/abozhinov/pen/XWbqjEJ Steps to reproduce the problem:If components existing delete them all.Drag a new carousel block. Select the first children's container.Click on the DUPLICATE icon to create a new component.After that try to select the newest component and then se...

abozhinov

When overwrite these two methods in 'select-comp' command everything works perfectly. The problem was that "el" doesn't exist in the DOM. ` onHovered(em, component) { let result = {}; if (component) { const { view } = component; const { el...

abozhinov

The same result you can get when trigger render instead of reset.

abozhinov

@artf if you try on the demo is the same. Just drag the carousel and click on the slide. <img width="1440" alt="Screenshot 2020-03-16 at 14 58 23" src="https://user-images.githubusercontent.com/1404839/76760669-b8b75780-6796-11ea-8e24-8946...

#2645March 13, 2020by Rasazna2 answers
2 reactions

how to add new content to the intended component without removing the previously added component content

WARNING READ and FOLLOW next 5 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdUse the GitHub Issues EXCLUSIVELY for BUGS, FEATURE REQUESTS or QUESTIONS. Prefix the title of the issue with its context, eg. [Bug]: ....Do a quick...

pouyamiralayi

append

Rasazna

I want to add data to the div component without removing the previosuly added data using the trait manager option is there a way to do it. Can some one help m e with a sample code for this.