#2885July 9, 2020by Drishya12345No answers
WARNING READ and FOLLOW next 3 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdDo a quick SEARCH first, to see if someone else didn't open the same issueAll relative statements/questions have to be filled/answered, otherwise, th...
#2883July 8, 2020by j2lNo answers
Hello, Version: 0.16.18 Are you able to reproduce the bug from the demo? [X] Yes [ ] No What is the expected behavior? Only add one trait, being able to test empty trait addition Describe the bug detailed Adding trait with: Adds a new empty trait ... each time this component is selected: Because getAttributes is undef...
#2882July 8, 2020by ghost2 answers
Version: 0.16.18 Are you able to reproduce the bug from the demo? [x ] Yes https://jsfiddle.net/triawarman/tmcoqxhp/ What is the expected behavior? When drag "caption" block to canvas, will add element <caption>Insert text here</caption> What is the current behavior? Adding text "Insert text here" directly to the canv...
artf
Actually, HTML allows <caption> only inside <table>s (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/caption) so, the parser will always convert it in a text node, indeed the real issue is not the caption but the render of the t...
ghost
hy @artf thanks for your reply. actually after <caption> problem, i found another problems with table, i cant drag and drop <tr> to the <table>, and <th> <td> to the <tr> the demo code is here: https://jsfiddle.net/triawarman/tpnco4v6/ i f...
#2880July 8, 2020by adriangrochNo answers
Version: 0.16.18 Are you able to reproduce the bug from the demo? Yes What is the expected behavior? The "Helvetica" font should be selected when loaded. Describe the bug detailed Since Helvetica is a sans-serif font, it should be defined as one for the typography selector. What is the current behavior? Currently, it...
#2878July 6, 2020by fedulovivan3 answers
Steps:open newsletter demo at https://grapesjs.com/demo-newsletter-editor.htmlclean the canvasdrop "Text Section"select any word within H1, e.g. word "title"press Bold modifier once or twice Expected:Selected text became non-bold Actual:Text remains bold Those steps above are for CKE editor, which is now enabled on ne...
robsonsobral
This looks like a flaw of logic to me. <Hn> elements aren't bold, but titles. As you mentioned, even the browser native execCommand, used on built-in editor, doesn't know what to do. @fedulovivan, do you have a suggestion of a possible HTM...
fedulovivan
Hi, @robsonsobral An html, generated by built-in RTE is correct: Original: <h1>Insert title here</h1> After making word "title" non-bold: <h1>Insert <span style="font-weight: normal">title</span> here</h1> The problem is it's not rendered...
robsonsobral
I dig a little into this. After the blur event, the markup changes from <span style="font-weight: normal">title</span> to <span data-gjs-type="default"><span data-gjs-type="text">title </span></span>. If I try again, it becomes <span data-...
#2877July 5, 2020by robsonsobral2 answers
Hi! The strikethrough command on RTE uses the obsolete tag <strike>:This feature is obsolete. Although it may still work in some browsers, its use is discouraged since it could be removed at any time. Try to avoid using it. For no longer relevant or no longer accurate text, the recommended tag is <s>.This element is d...
artf
Would you like to create a PR? :)
robsonsobral
I'll send one later today!
#2876July 4, 2020by fedulovivan1 answer
Steps to reproduce:open newsletter demo at https://grapesjs.com/demo-newsletter-editor.htmlclean canvasplace "1/3 section"place "Image" in the middle columntry to resize image - works correctlymove selection to images's parent with click on upper arrow - resizing frame was moved to table cell which is incorrect. actio...
artf
Nice, it will be fixed in the next release
#2874July 3, 2020by acxvgalanov2 answers
Actual behavior: If the toolbar is placed on the element that is positioned near the bottom border, it may overflow the canvas and be partly hidden. It can be reproduced with the default toolbar: screenshot, but it's especially noticeable when the toolbar is customized and tall enough so some elements are inaccessible...
artf
Let me know if you're still working on the PR
no-response[bot]
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take ac...
#2873July 3, 2020by RJCAM3 answers
Hi, I've noticed that some form components (like checkbox, radio and select) are not working when gjs is initialized with the Preset Webpage Plugin like in the example below: You can confirm this issue with the online Webpage Demo too https://grapesjs.com/demo.html Expected Behavior: can select all of them normally (o...
artf
Ah ok, now I got it. Yeah, forms plugin avoids some default input behavior, so it's intended. I agree that in the preview mode those behaviors could be re-enabled but I think that part might be integrated as a plugin (eg. by using event li...
RJCAM
Hum...ok, I'll try to do that, thanks for the help :+1:
artf
After rebuild the plugin the behavior works as expected, so problem resolved. Maybe there is a reason why I've done that?! 😅 Via plugin, you can simply extend those components and override handleClick function with your logic, where you p...
#2871July 2, 2020by acxvgalanov1 answer
GrapesJs version: 0.16.18; Steps to reproduce:Add Image block, set any image;Select the added block;Double click and change image to any other image with a different size and/or ratio. Expected result: The image is updated, the toolbar position and selection frame are updated. Actual result: The image is updated, the...
artf
Thanks for the report, it will be fixed in the next release