#2637March 11, 2020by mcottret3 answers
Hello again :) Our team recently started customising the editor & removing the webpage preset, and we might have found some bugs related to the preview mode:When exiting preview mode, an error can be raised if the default options panel has been removed, or if the sw-visibility button has been removed from it (from her...
artf
button would already be deactivated by the time Preview's run would be executed no matter what, is that correct ? oh yeah, right 🤦♂ From your reply on the linked issue, I understand this behaviour is intended, so maybe the solution is si...
artf
Thanks @mcottret for all the references, really well-written issue :)When the preview & the sw-visibility buttons are in the same panel, the behaviour introduced by #2589 breaks, this seems to come from the ButtonView's active change liste...
mcottret
Thanks for the reply @artf ! I'm sorry but I'm not sure how to make this work, from what I understand the active change listener gets executed before the Preview's run, so the sw-visibility button would already be deactivated by the time P...
#2636March 11, 2020by mcottret2 answers
Hello again :) Our team recently started customising the editor & removing the webpage preset, and we might have found some bugs related to the preview mode: When using the built-in preview mode with custom panels, the custom panels are not hidden when entering preview mode. If we look at the source, the preview comma...
artf
A proposed solution would be to rather loop through the panels collection (retrieved via editor.Panels.getPanels) and toggle their visible attribute. What do you think ? Yeah, it makes totally sense. Go ahead with the PR, thank you very mu...
mcottret
Great ! #2669 opened.
#2624March 5, 2020by kierenayima1 answer
Currently using GrapeJS for a project that I am working on locally and integrated it with some tailwind UI components. It mostly works great, but I have noticed that making changes on some elements does not work (for example, changing text color or formatting). Looking at it further I can see that this is because the...
artf
Thanks for the report @kierenayima Selectors will be escaped in the CSS in the next release
#2622March 4, 2020by light-effect1 answer
am.addType('svg-icon', { view: { // getPreview() and getInfo() are just few helpers, you can // override the entire template with template() // Check the base template() here: // https://github.com/artf/grapesjs/blob/dev/src/asset_manager/view/AssetView.js getPreview() { return <div style="text-align: center">${this.m...
artf
Follow the issue template if you're submitting a bug, you have to create, at least, a reproducible demo
#2621March 4, 2020by yuzhva3 answers
While creating a custom plugin, in case, when editor.Panels.addPanel is using inside plugin function - buttons are duplicated. Example: https://jsfiddle.net/kncdah8b/ Buttons are not duplicated:when using single Panels.addButton API while loop buttons separatelywhen adding panel after editor const editor = grapesjs.in...
yuzhva
Closing the issue, as I found the other solution: But the issue with editor.Panels.addPanel({ buttons: [] }); still exist (=
artf
Thanks @YUzhva for the report and the solution. I'll try to check this out
hellocaio
Same here, I tested the panels example (Getting started) in the docs too and keep getting duplicate buttons. @yuzhva solution works, thanks :)
#2619March 3, 2020by mcottret2 answers
Hi, and thanks for the great library ! We might have found the following bug when playing around with it: When adding a new default "Image Block" without further configuration (leaving the default image placeholder), the exported / generated HTML code embeds the default svg element as the image's src attribute value (...
mcottret
Thanks ! #2620 opened.
artf
Thanks for the report Mathieugrapesjs/src/dom_components/model/ComponentImage.js's getAttrToHTML function should call this.getSrcResult (not sure whether or not to use the fallback option) rather than this.get('src') to retrieve the base64...
#2616March 3, 2020by Rasazna2 answers
WARNING READ and FOLLOW next 5 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdUse the GitHub Issues EXCLUSIVELY for BUGS, FEATURE REQUESTS or QUESTIONS. Prefix the title of the issue with its context, eg. [Bug]: ....Do a quick...
pouyamiralayi
@Rasazna in below example, i am using it inside a `selected` event, so when ever you click on an item, your changes apply! Cheers!
Rasazna
i did not understand how to use editor.getSelected().append(<div>...); feature . can someone give an example for it
#2615March 2, 2020by vinu-noldor2 answers
Hi @artf , Thank you for creating this amazing repo! I came across a bug that is present in the website demo (https://grapesjs.com/demo.html) and in my local version. When I add a map block and I click on it to change trait values, I get an error like this in the console: I looked through the main grapesjs repo and co...
artf
Seems like a false positive, I've put the warning to help in debugging but forgot that not found types will fallback to simple inputs with <input type="TRAIT-TYPE".... I'll try to fix it for the next release
#2613March 2, 2020by Rasazna3 answers
WARNING READ and FOLLOW next 5 steps, then REMOVE them before posting the issueFollow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.mdUse the GitHub Issues EXCLUSIVELY for BUGS, FEATURE REQUESTS or QUESTIONS. Prefix the title of the issue with its context, eg. [Bug]: ....Do a quick...
Rasazna
I am using gridly and high charts as two different blocks. I will drag the gridly block first and drag the the chart into the gridly block. How can this be done. I am only able to place the chart around the gridly block. But I want it insi...
artf
Please read the documentation first, seems like you have no idea how Components work...
Rasazna
can you just help me how to do it . I still could not figure it out. A sample code would be really helpful.
#2605February 27, 2020by alesub2 answers
First of all, thank you for this great tool.I'm using the latest version.The bug happens with a local copy of GrapesJS.MacOS - latest Chrome browserThe bug is not present on the demoExpected behavior: have the editor loading without any errorsWhat happens instead: I get a 404 error when the editor is appending styles...
artf
I think it's coming from cssIcons, seems like I forgot to check the value somewhere
alesub
Amazing, looking forward for the next release! Thanks!